This is AdBlock's old support site. It is available for archival purposes only. To create a new discussion, or to visit the up-to-date knowledge base, please visit help.getadblock.com

Undo's use of the disable list overrides any attempt to re-enable blocks

Tim WB's Avatar

Tim WB

14 Jun, 2015 05:10 AM

I was confused when I blocked some parts of a web page, disabled the blocks using "undo my blocks on this domain", then tried to re-enable them, but it didn't work.

Steps to reproduce:
1. Block an element
2. Click "Undo my blocks on this domain"
3. Block the element again
4. Refresh the page

Expected result:
The element is blocked.
Undo leaves the block list and disable list as if I'd never blocked anything (after step 2).
Repeating the block in step 3 leaves the block list identical to step 1.

Actual result:
The element is not blocked.
Undo leaves the disable list with the element I tried to block in it from step 2 onwards.
Repeating the block in step 3 doesn't add it to the block list.

  1. 1 Posted by Tim WB on 14 Jun, 2015 05:18 AM

    Tim WB's Avatar

    I'm using AdBlock 2.35 on Safari 8.0.6 (10600.6.3) on OS X Yosemite 10.10.3 (14D136)

  2. Support Staff 2 Posted by Rhana on 14 Jun, 2015 01:11 PM

    Rhana's Avatar

    Hi Tim,

    I'm having trouble following your instructions. How exactly are you blocking an element? With AdBlock running, there shouldn't be any ads to block manually. With AdBlock paused entirely, are you still seeing the menu option "Block an ad on this page"?

    Also, can you please provide a link to a page where this is happening?

    Rhana
    AdBlock Community Manager

  3. 3 Posted by Tim Wilson-Brow... on 14 Jun, 2015 02:37 PM

    Tim Wilson-Brown's Avatar

    Rhana,

    > I'm having trouble following your instructions. How exactly are you blocking an element?
    >

    I am right-clicking on the element and selecting "Block this ad"
    But this issue also occurs with "Block an ad on this page"

    > With AdBlock running, there shouldn't be any ads to block manually.
    >

    I'm not sure this is particularly relevant, but:
    I think you've overly optimistic about the coverage of AdBlock.
    Perhaps you mainly use sites in the US? Coverage in other countries is not that great.
    Regardless, I may choose to block elements that I find annoying, regardless of whether others think they're "ads".

    > With AdBlock paused entirely, are you still seeing the menu option "Block an ad on this page"?
    >

    I don't pause AdBlock at any point in my instructions.
    But to answer your question, no, those menu items disappear when AdBlock is paused.

    > Also, can you please provide a link to a page where this is happening?
    >

    One of the issues I'm having happens on many pages.
    The other has only happened on a few sites, and I can't seem to reproduce it.

    The general issue is that the "Undo my blocks on this domain" right-click menu item doesn't do anything:

    Let's assume I dislike the Google logo on https://google.com/ <https://google.com/> and block it using AdBlock:

    1. Go to https://google.com/ <https://google.com/>
    2. Right-click on the Google logo and choose "Block this ad"
    3. Choose the "IMG" tag as the blocked element and click "Looks good"
    4. The defaults are ok here
    5. Choose "Block it"

    Now the Google logo is gone, as I would expect.

    But I change my mind, and want it back:

    6. Right-click anywhere on the page.
    7. Select "Undo my blocks on this domain" (does your version of AdBlock have this feature?)

    Nothing happens. Even when the page is refreshed. This is not working as I expect.
    I expect the Google logo to come back.

    So I try a different method:

    8. Click the AdBlock button in the Safari toolbar
    9. Select "Undo my blocks on this domain"
    10. Answer "Yes" to the "Are you sure" dialog (maybe this dialog is why the menu item doesn't work)

    I now see the Google logo again.
    So using the AdBlock toolbar button works as expected on some sites, but not on others.

    The specific issue is that the "Undo my blocks on this domain" toolbar button menu item doesn't work as expected. But, unfortunately, I can't reproduce the issue now, so it's hard for me to work out exactly what caused it.

    Here's what happens every time:

    1. Go to https://swarmsim.github.io/ <https://swarmsim.github.io/>
    2. Right-click on "NN larvae" (I actually block a different tab that doesn't appear early in the game, but that shouldn't matter)
    3. Choose the "A" tag as the blocked element and click "Looks good"
    Before you click "Looks Good", the complete blocked tag should read:
    <A
    class="ng-binding"
    href="#/tab/larva" >
    4. Select "href will be #/tab/larva" (I wonder if the # is messing with AdBlock?)
    5. Choose "Block it"

    Now, when I refresh the page, the larvae tab is gone, as I would expect.

    But I change my mind, and want it back:

    6. Right-click anywhere on the page.
    7. Select "Undo my blocks on this domain" (does your version of AdBlock have this feature?)

    Nothing happens. Even when the page is refreshed. This is not working as I expect.
    I expect the larvae tab to come back.

    So I try a different method:

    8. Click the AdBlock button in the Safari toolbar
    9. Select "Undo my blocks on this domain"
    10. Answer "Yes" to the "Are you sure" dialog (maybe this dialog is why the menu item doesn't work)

    Here's the result I can't reproduce:

    Instead of undoing the blocks, AdBlock adds them to the disabled filters list instead.
    This means that I can't ever block those particular tabs again.
    I'm not sure how the filters got switched around this way, but clearing the disabled filters list fixed it.

    It had happened to another site as well, at some point in the past - I had blocked a large image that http://thedailywtf.com <http://thedailywtf.com/> had embedded from wikimedia commons. But I can't find the exact image or filter.

  4. 4 Posted by Tomáš on 14 Jun, 2015 05:26 PM

    Tomáš's Avatar

    Hi Tim,

    I've been able to confirm, that "Undo my blocks on this domain" from context menu doesn't work as it should. However, when I click on AdBlock toolbar button and choose "Undo my blocks on this domain" there, it does work.

    I am not able to confirm, that the chosen filter from ad-wizard goes to disabled filters, it works as it should (filter gets added to the custom filters).

    Can you please click the AdBlock button, select Options, then click SUPPORT. Next to "Have our team requested some debug info?" click here. Paste the text from the box into this discussion.

    Thanks,
    Tomáš
    Extension Developer

  5. Support Staff 5 Posted by Rhana on 14 Jan, 2016 05:13 PM

    Rhana's Avatar

    Hi Tim,

    The issue you reported was resolved in AdBlock version 2.46, released this week. You should receive the update automatically soon if you haven't already.

    Please let us know if there's any way we can assist in the future!

    Rhana
    AdBlock Community Manager

  6. Rhana closed this discussion on 14 Jan, 2016 05:13 PM.

Discussions are closed to public comments.
If you need help with AdBlock please start a new discussion.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac